Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply SAITS embedding strategy to new added models #343

Merged
merged 22 commits into from
Apr 9, 2024
Merged

Apply SAITS embedding strategy to new added models #343

merged 22 commits into from
Apr 9, 2024

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Apr 9, 2024

What does this PR do?

  1. fixing the comment here New Model #295 (comment);

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu
feat: make Autoformer and TimesNet both take the missing mask as a pa…
5bcfe57 
…rt of input;
@WenjieDu
Merge branch '(feat)add_dlinear' into (feat)input_missingness_into_ti…
369351d 
…mesnet_autoformer
@WenjieDu
docs: add TODO tag for DLinear;
7918901
@WenjieDu
Merge branch 'dev' into (feat)input_missingness_into_timesnet_autoformer
c0320a4
@WenjieDu
feat: make ETSformer take the missing mask as a part of input;
6336714
@WenjieDu
Merge branch 'dev' into (feat)input_missingness_into_timesnet_autoformer
8fd5a12
@WenjieDu
feat: make FEDformer take the missing mask as a part of input;
f7e384e
@WenjieDu
docs: update the docs for Informer;
a1e127a
@WenjieDu
Merge branch 'dev' into (feat)add_informer
708f9fe
@WenjieDu
feat: add Informer as an imputation model;
8708853
@WenjieDu
Merge branch '(feat)add_informer' into (feat)input_missingness_into_t…
bee622c 
…imesnet_autoformer

# Conflicts:
#	pypots/imputation/autoformer/modules/core.py
#	pypots/nn/modules/transformer/embedding.py
@WenjieDu
feat: make Informer take the missing mask as a part of input;
5cd5887
@WenjieDu
Merge branch 'dev' into (feat)input_missingness_into_timesnet_autoformer
f5f92c8 
# Conflicts:
#	pypots/imputation/informer/__init__.py
#	pypots/imputation/informer/model.py
#	pypots/imputation/informer/modules/core.py
#	tests/imputation/informer.py
@WenjieDu
feat: make Informer take the missing mask as a part of input;
ca77697
@WenjieDu
feat: make DLinear take the missing mask as a part of input;
c8b0828
@WenjieDu
refactor: DLinear code refactor;
b34a020
@WenjieDu
refactor: DLinear code refactor;
83dccd2
@WenjieDu
feat: make Crossformer take the missing mask as a part of input;
3d797e4
@WenjieDu
feat: make PatchTST take the missing mask as a part of input;
bd1b990
@WenjieDu
refactor: separate n_steps of K and Q, this is necessary for Crossfor…
58b4361 
…mer;
@WenjieDu
refactor: add comments, and rename some layers and variables;
9b94bf1
@WenjieDu WenjieDu changed the base branch from main to dev April 9, 2024 10:18
@coveralls
Copy link
Collaborator

coveralls commented Apr 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8614163418

Details

  • 79 of 80 (98.75%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 81.03%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/dlinear/modules/core.py 33 34 97.06%
Files with Coverage Reduction New Missed Lines %
pypots/imputation/fedformer/modules/submodules.py 2 44.2%
Totals Coverage Status
Change from base Build 8602662623: 0.2%
Covered Lines: 6847
Relevant Lines: 8450
💛 - Coveralls

@WenjieDu WenjieDu merged commit 2f66d38 into dev Apr 9, 2024
8 checks passed
@WenjieDu WenjieDu deleted the (feat)apply_saits_embedding_to_new_models branch April 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WenjieDu @coveralls