Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename save_model() and load_model() into save() and load() #247

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

Replace save_model() and load_model() with save() and load(). Old functions save_model() and load_model() are still kept for compatibility and will be removed in the future.

Before submitting

  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit 73d8ada into dev Nov 29, 2023
12 of 21 checks passed
@WenjieDu WenjieDu deleted the temp_test_branch branch November 29, 2023 06:44
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7028965482

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 21 of 26 (80.77%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 83.343%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/base.py 21 26 80.77%
Files with Coverage Reduction New Missed Lines %
pypots/base.py 1 69.68%
pypots/classification/base.py 1 74.07%
pypots/cli/env.py 1 65.31%
pypots/data/base.py 1 80.77%
Totals Coverage Status
Change from base Build 7028744993: -0.1%
Covered Lines: 4443
Relevant Lines: 5331

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants