Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSDI gt_mask is wrong in PyPOTS implementation #254

Closed
1 of 2 tasks
WenjieDu opened this issue Dec 2, 2023 · 0 comments
Closed
1 of 2 tasks

CSDI gt_mask is wrong in PyPOTS implementation #254

WenjieDu opened this issue Dec 2, 2023 · 0 comments
Assignees
@WenjieDu
Labels
bug Something isn't working
Milestone
v0.3

Comments

@WenjieDu
Copy link
Owner

WenjieDu commented Dec 2, 2023 •
edited
Loading

1. System Info

CSDI official implementation:
https://github.com/ermongroup/CSDI/blob/main/dataset_physio.py#L47-L54

PyPOTS implementation
https://github.com/WenjieDu/PyPOTS/blob/main/pypots/imputation/csdi/data.py#L79

gt_mask has a very misleading name. In the official implementation, it is actually not the mask indicating ground truth values, but the missing mask of observed values after random masking. In current PyPOTS implementation, we return indicating mask as gt_mask, and this is a bug.

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

pass

4. Expected behavior

pass
@WenjieDu WenjieDu added the bug Something isn't working label Dec 2, 2023
@WenjieDu WenjieDu self-assigned this Dec 2, 2023
WenjieDu added a commit that referenced this issue Dec 4, 2023
@WenjieDu
fix: error in gt_mask mentioned in #254;
e6f3292
@WenjieDu WenjieDu mentioned this issue Dec 4, 2023
Merged
3 tasks
WenjieDu added a commit that referenced this issue Dec 4, 2023
@WenjieDu
Fixing CSDI gtmask bug (#255)
2542a0c 
* fix: error in gt_mask mentioned in #254;

* refactor: add some code comments;
@WenjieDu WenjieDu closed this as completed Dec 4, 2023
@WenjieDu WenjieDu added this to the v0.3 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WenjieDu WenjieDu

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@WenjieDu