Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package pypots.optim to separate optimizers from models, and update docs #107

Merged
merged 3 commits into from
May 14, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

Update docs and fixes #105. Add the package pypots.optim to help separate optimizers from models to:

  1. separate the hyperparameters of models and optimizers in PyPOTS, so that users don't have to put all hyperparameters
    in one place, which could result in a mess and be not readable.
  2. provide additional functionalities, such as learning rate scheduling, etc.

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit c25f0de into main May 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate optimizers and models
1 participant