Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate optimizers and models #105

Closed
WenjieDu opened this issue May 14, 2023 · 0 comments · Fixed by #107
Closed

Separate optimizers and models #105

WenjieDu opened this issue May 14, 2023 · 0 comments · Fixed by #107
Labels
enhancement New feature or request new feature Proposing to add a new feature

Comments

@WenjieDu
Copy link
Owner

1. Feature description

To make the framework more usable, we should separate models and optimizers, for example:

saits=SAITS(
n_steps=48,
n_features=37,
n_layers=3,
...
optimizer=pypots.optim.Adam(),
...
)

2. Motivation

Such a design can give users more options, and make PyPOTS framework more powerful. For example, we can add more functionalities into pypots.optim.Optimizer classes, like lr scheduler.

3. Your contribution

Will make a PR to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature Proposing to add a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant