Skip to content

Commit

Permalink
Merge pull request #78 from WenjieDu/dev
Browse files Browse the repository at this point in the history
Add PR template, and make the dependencies consistent in all config files
  • Loading branch information
WenjieDu committed May 1, 2023
2 parents df8ddfc + e211de0 commit 242bdc9
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 6 deletions.
22 changes: 22 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# What does this PR do?

<!--
Congrats! You've made it this far! You're not quite done yet though.
Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution 😉.
Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change.
Once you're done, I will review your PR shortly. I may suggest changes to make the code even better 🤝.
-->

<!-- Remove if not applicable -->

Fixes # (issue)


## Before submitting
- [ ] This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
- [ ] Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have written necessary tests and already run them locally.
8 changes: 5 additions & 3 deletions .github/workflows/testing_daily.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Daily Testing

on:
push:
branches:
- fix_dependency_error_in_daily_testing
schedule:
# https://crontab.guru. Run everyday at 0:00AM UTC, i.e. 08:00AM Beijing, i.e. 08:00PM Montreal (summer time)
- cron: "0 0 * * *"
Expand Down Expand Up @@ -42,8 +45,7 @@ jobs:
- name: Install other dependencies
run: |
pip install -e ".[optional]" -f "https://data.pyg.org/whl/torch-${{ matrix.torch-version }}+cpu.html"
pip install -e ".[basic]"
pip install -e ".[test]"
pip install -e ".[dev]"
- name: Fetch the test environment details
run: |
Expand All @@ -62,4 +64,4 @@ jobs:
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: "coverage.lcov"
path-to-lcov: "coverage.lcov"
4 changes: 2 additions & 2 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ extend-ignore =

# basic dependencies
basic =
numpy>=1.23.3
scikit-learn>=0.24.1
numpy
scikit-learn
pandas<2.0.0
torch>=1.10.0
tensorboard
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
author="Wenjie Du",
author_email="[email protected]",
url="https://github.com/WenjieDu/PyPOTS",
download_url="https://github.com/WenjieDu/PyPOTS/archive/master.zip",
download_url="https://github.com/WenjieDu/PyPOTS/archive/main.zip",
keywords=[
"data mining",
"neural networks",
Expand Down

0 comments on commit 242bdc9

Please sign in to comment.