Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage build #303

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Add coverage build #303

merged 1 commit into from
Feb 15, 2017

Conversation

binji
Copy link
Member

@binji binji commented Feb 14, 2017

This should be helpful in determining which (of any) of the wabt-specific tests we can remove in favor of the spec tests.

sbc100
sbc100 approved these changes Feb 15, 2017
View reviewed changes
Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! presumably we could get a metric and add a presubmit to prevent coverage regressions at some point too?

@binji
Copy link
Member Author

binji commented Feb 15, 2017

Maybe so, that'd be pretty cool. :)

@binji binji merged commit e077c23 into master Feb 15, 2017
@binji binji deleted the coverage branch February 15, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binji @sbc100