Fix 2nd argument's type definition of some f32/f64 opcodes in opcde.def #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2nd ret type of these opcodes are different from the wasm spec
|
It looks like its the second argument type you are changing here, not the return type? Other than updating the PR description to reflect that this lgtm! Thanks. Kind of shame that this isn't pragmatically verified somehow/somewhere in wabt. |
sbc100
approved these changes
Jun 21, 2024
Thank you, it's my typo, now it has been changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2nd argument's type of these opcodes are different from the wasm spec