New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace table.full with table.fill #2433

Merged

keithw merged 1 commit into WebAssembly:main from mjbshaw:patch-1

Jun 21, 2024

Contributor

mjbshaw commented Jun 21, 2024

Presumably this was a typo and the TableFill op code (text instruction: table.fill) token should use the word "fill" instead of "full."


Replace table.full with table.fill

1c48565

Member

keithw commented Jun 21, 2024

Thanks, nice catch! I think this string is only used to print the error message in a case like

(func v128.const table.fill 0 0 drop)

which currently generates:

error: Unexpected type at start of simd constant. Expected one of: i8x16, i16x8, i32x4, i64x2, f32x4, f64x2. Found "table.full".

keithw approved these changes

View reviewed changes

keithw merged commit 65b61e0 into WebAssembly:main

18 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment