wast2json: Support outputting negative numbers for v128 values #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enverbalalic
force-pushed
the
wast2json-negative-numbers
branch
2 times, most recently
from
29241a8
to
759a281
Compare
Enverbalalic
force-pushed
the
wast2json-negative-numbers
branch
from
759a281
to
525e9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wast2json doesn't generate correct values for v128 arrays when negative numbers are in the .wast file.
-1 will become 65535 for i16. This corrects that.
Difference is easily visible in the
simd_iNxM_arithtests