Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden against invalid alignment #2411

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SoniEx2
Copy link
Contributor

@SoniEx2 SoniEx2 commented May 3, 2024

Chasing https://crbug.com/oss-fuzz/51561

Let's see if this breaks anything...

The issue only triggers if both conditions are true:

  • Multi-memory is enabled
  • Alignment (masked) is between 32 and 63

@SoniEx2 SoniEx2 force-pushed the fix-undefined-shifts branch 2 times, most recently from 41931ae to a517995 Compare May 4, 2024 00:03
@SoniEx2
Copy link
Contributor Author

SoniEx2 commented May 4, 2024

cc @keithw because oss-fuzz

Copy link
Member

@keithw keithw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

src/binary-reader.cc Outdated Show resolved Hide resolved
test/regress/undefined-shifts.txt Show resolved Hide resolved
@SoniEx2 SoniEx2 requested a review from keithw May 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants