Fix implicit br return #2324
Draft
Fix implicit br return #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR probably makes you the leading active wasm-decompiler person we have. :-) Your strategy sounds good but I don't think I have any better ideas... |
|
Hmm ok. I'll work on finding a solution that works, then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An in-progress fix for #2304. For now, I believe it's working for any
brdepth. However, I'm not really sure how to handle thebr_ifcase. Should it be replaced with anifand then areturn? If so, I couldn't really find a way to create a newIfExprand compile that on the fly. Maybe someone with more experience with the decompiler source code has a good way to do it.