Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate wasm-c-api on big-endian and fix rot13 test #2161

Closed
wants to merge 4 commits into from

Conversation

SoniEx2
Copy link
Contributor

@SoniEx2 SoniEx2 commented Mar 7, 2023

This includes #1971 and fixes #1972

Rationale in #1972 (comment)

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If thats all it takes to support these platforms its seems reasonable to me.

ENV TZ=UTC

RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && \
echo $TZ > /etc/timezone && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this TZ hacking is needed.. seems a little odd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea, ask #1971 ? this PR is based on that one.

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Mar 7, 2023

this should not have broken the main build... where's the typo? >.<

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Mar 7, 2023

found the typo XD

@SoniEx2

This comment was marked as resolved.

@SoniEx2 SoniEx2 force-pushed the s390x-rot13 branch 2 times, most recently from 4264e91 to 0921fb3 Compare October 29, 2023 15:42
@SoniEx2 SoniEx2 changed the title Tentatively fix s390x test Deprecate wasm-c-api on big-endian and fix rot13 test Oct 29, 2023
@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Oct 29, 2023

it's possible these were always broken, but, uh, anyone wanna bisect these remaining failures?

edit: okay so simd and atomics are something we'll have to fix (in a separate PR). we're not sure about the failing traps tho. also, i386 support is not up to us.

@SoniEx2
Copy link
Contributor Author

SoniEx2 commented Oct 29, 2023

perhaps cc @rathann about i386/i686? also @alexreinking do you know anything about using a cross-compiler with these? running the whole compiler under qemu seems unnecessarily slow...

@SoniEx2 SoniEx2 marked this pull request as ready for review October 29, 2023 21:01
@rathann
Copy link
Contributor

rathann commented Nov 1, 2023

perhaps cc @rathann about i386/i686? also @alexreinking do you know anything about using a cross-compiler with these? running the whole compiler under qemu seems unnecessarily slow...

x86_64 builds of gcc can compile for i686 without qemu or cross-compilation.

@SoniEx2 SoniEx2 marked this pull request as draft November 15, 2023 11:20
@SoniEx2 SoniEx2 closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rot13 test fails on s390x
4 participants