fix wasm2c tests on 32-bit #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spectest_make_externref() in test/spec-wasm2c-prefix.c:203 assumes that u64 (uint64_t) can be converted to wasm_rt_externref_t (void *). This is not the case on 32-bit platforms. ``` - test/regress/regress-2039.txt expected error code 0, got 1. STDERR MISMATCH: --- expected +++ actual @@ -0,0 +1,19 @@ +out/test/regress/regress-2039/regress-2039-main.c: In function ‘spectest_make_externref’: +out/test/regress/regress-2039/regress-2039-main.c:205:10: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] + 205 | return (wasm_rt_externref_t)(x + 1); // externref(0) is not null + | ^ ``` The same error occurs with all wasm2c tests. This fixes WebAssembly#2099.
|
Would be nice to have CI for i386 but I guess (#1971) we've still got a ways to go there. |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spectest_make_externref() in test/spec-wasm2c-prefix.c:203 assumes that
u64(uint64_t) can be converted towasm_rt_externref_t(void *). This is not the case on 32-bit platforms.The same error occurs with all wasm2c tests.
This fixes #2099.