-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per instance, cross platform library sandboxing support in wasm2c #1721
base: main
Are you sure you want to change the base?
Conversation
… structs runtime data into wasmc module, add shared library for runtime
…ces and init code to use these
…ookup for globals, tables, memories
Would it be practical to split those two, @shravanrn ? If so that sounds good to me. The work to split it out might be saved in being able to land one part first and not keep discussions on a single big PR (that waits on all items for landing). But, if it's not practical to split out, I think it's ok for me to review as it is. |
Sorry for the delay! Some last minute deadlines on my side. I'll be back to updating this PR and addressing the comments in a day or two |
@kripken @sbc100 As you suggested, i think it may be easier to upstream this in batches. So, rather than landing this PR, @talg from our sandboxing team will be submitting PRs to upstream these changes in batches. This should allow us to more easily review and land things. Thanks @talg! :) Let me know if you have any thoughts or concerns. Will close this PR if the above plan makes sense to you |
Sounds like a good plan to me! |
@shravanrn is most of this stuff landed now? Are these still things that remain? i.e. should we close this now? |
@sbc100 At least three of these points haven't been merged in
But I think we can close this bug, we don't need to track these here. At some point, if I get around to re-implementing this, I'll open fresh issues/PRs |
OK, closing this for now. Thanks for all the contributions @shravanrn! |
@kripken Per our discussion here is the PR with all the wasm2c changes we needed to make to allow wasm2c to be used to sandbox libraries in the Firefox browser. (Fyi @deian) Briefly here are some of the more notable changes made)
I think this PR will likely be a starting point for discussion and we can discuss what we need to change/update so we can land this without issues