wasm-objdump: Report data segment names #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
named_segments
branch
from
785c1d2
to
62cc3a5
Compare
tlively
reviewed
Dec 10, 2020
src/binary-reader-objdump.cc
Outdated
Comment on lines
673
to
674
| LogOpcode(immediate_len, "%d <" PRIstringview ">", value, | ||
| WABT_PRINTF_STRING_VIEW_ARG(name)); |
There was a problem hiding this comment.
Looks like value2 is missing here.
| 000008d: 656c 656d 31 elem1 ; elem name 0 | ||
| 0000089: 08 ; FIXUP subsection size | ||
| 000004a: 47 ; FIXUP section size | ||
| 0000089: warning: out-of-order sub-section |
There was a problem hiding this comment.
The order was wrong in src/binary-writer.cc .. this change has a fix that that. Want me to split it out?
There was a problem hiding this comment.
Ah, got it, thanks! Keeping it in seems fine.
| @@ -204,10 +208,12 @@ Custom: | |||
| - memory[0] <mem2> | |||
| - global[0] <g1> | |||
| - global[1] <g2> | |||
| - elemseg[0] <elem1> | |||
There was a problem hiding this comment.
Where does this "elem1" come from?
There was a problem hiding this comment.
The out of order name section meant is wasn't being displayed here.
Also fix ordering of data names and table segment names.
sbc100
force-pushed
the
named_segments
branch
from
62cc3a5
to
5f0a359
Compare
tlively
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix ordering of data names and table segment names.