Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow non-zero memidx when bulk memory disabled #1546

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Disallow non-zero memidx when bulk memory disabled #1546

merged 1 commit into from
Sep 17, 2020

Conversation

chfast
Copy link
Contributor

@chfast chfast commented Sep 17, 2020

If bulk memory extension is disabled, do not allow memory index in the
data segment other than zero.

@chfast
Disallow non-zero memidx when bulk memory disabled
1778c44 
If bulk memory extension is disabled, do not allow memory index in the
data segment other than zero.
binji
binji approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@binji binji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm!

@chfast
Copy link
Contributor Author

chfast commented Sep 17, 2020

The spectest additions will follow soon.

@binji binji merged commit 122f79d into WebAssembly:master Sep 17, 2020
@chfast chfast mentioned this pull request Sep 17, 2020
Merged
@chfast chfast deleted the binary_reader_bulk_memory_disabled branch September 18, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binji binji binji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chfast @binji