[js-api][test] Refine DefaultValue for new reference types #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefaultValue will return undefined for externref as before, but for other nullable reference types will return null. For non-nullable reference types, operations like grow and set should error if the value to set is missing. Also adds WPT tests for the error cases. This requires some updates to wasm-module-builder.js as well. Fixes issue WebAssembly#501
Co-authored-by: Andreas Rossberg <[email protected]>
|
Thanks for the suggestions! Should be updated now:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #501 and adjust
DefaultValuein the JS API so that it delegates to a embedder API function in the core spec, with a special case forexternrefto useundefined.Note that for
anyrefand other non-externref types it will usenullas the default value. For non-null types, it produceserrorand that is thrown as aTypeErrorforWebAssembly.Table.prototype.setandWebAssembly.Table.prototype.grow.Rendered spec change for the core spec:
Rendered change for
DefaultValue(there are changes to use sites too, not shown):The PR also adds a new WPT test for the error cases specifically. Both Firefox and Chrome passed the test when I tried it out.