Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for #516 to the test suite #518

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

fitzgen
Copy link
Contributor

@fitzgen fitzgen commented Feb 7, 2024

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But since the issue it tests actually is the typing of br_on_null, I think it would be more appropriate to add this test to br_on_null.wast.

@fitzgen
Copy link
Contributor Author

fitzgen commented Feb 7, 2024

There isn't a br_on_null.wast in the gc directory. Should I create one?

@rossberg
Copy link
Member

rossberg commented Feb 7, 2024

It's in the main directory. But you'll need to modify the example to avoid the use of GC features (which should be inessential to the issue). E.g. with some use of subtyping that works with just the funcref proposal.

@fitzgen
Copy link
Contributor Author

fitzgen commented Feb 7, 2024

@rossberg rewrote it to use (ref null $ty) and funcref instead of structref and anyref and moved the test into br_on_null.wast.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg rossberg merged commit d871d12 into WebAssembly:main Feb 7, 2024
1 check passed
@fitzgen fitzgen deleted the patch-2 branch February 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants