OrgView 대략적 구현 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukso96100
approved these changes
Aug 5, 2020
Comment on lines
+50
to
+57
| <ScrollView style={{ | ||
| flex: 1, | ||
| flexDirection: 'column', | ||
| marginHorizontal: 20, | ||
| marginVertical: 10, | ||
| }}> | ||
| {contents} | ||
| </ScrollView> |
There was a problem hiding this comment.
FlatList 로 구현해 보시는건 어떤가요?
Comment on lines
-37
to
+58
| <Image source={require('./assets/article.png')} /> | ||
| <Entypo style={styles.icon} name='news' size={36} color='black' /> | ||
| </TouchableHighlight> | ||
| <TouchableHighlight onPress={() => setState('org')}> | ||
| <Image source={require('./assets/organization.png')} /> | ||
| <Octicons style={styles.icon} name='organization' size={36} color='black' /> | ||
| </TouchableHighlight> | ||
| <TouchableHighlight onPress={() => setState('notice')}> | ||
| <Image source={require('./assets/notification.png')} /> | ||
| <Entypo style={styles.icon} name='notification' size={36} color='black' /> | ||
| </TouchableHighlight> | ||
| <TouchableHighlight onPress={() => setState('profile')}> | ||
| <Image source={require('./assets/account.png')} /> | ||
| <AntDesign style={styles.icon} name='profile' size={36} color='black' /> |
There was a problem hiding this comment.
가능하면 아이콘을 일관성 있게 한 종류의 아이콘 팩으로 통일하면 좋을 것 같네요
|
커멘트 참고하셔서 다음에 구현하실때 반영해주세요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrgView의 대충의 레이아웃을 잡았습니다.