Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

로그인 뷰 및 메인 뷰 구현 #1

Merged
merged 17 commits into from
Jul 23, 2020
Merged

로그인 뷰 및 메인 뷰 구현 #1

merged 17 commits into from
Jul 23, 2020

Conversation

onting
Copy link
Contributor

@onting onting commented Jul 21, 2020

로그인 뷰와 메인 뷰의 대략적인 레이아웃을 잡았습니다.

@onting onting requested a review from sukso96100 July 21, 2020 06:35
compo/loginview.js Outdated Show resolved Hide resolved
Comment on lines +36 to +47
<TouchableHighlight onPress={() => setState('feed')}>
<Image source={require('./assets/article.png')} />
</TouchableHighlight>
<TouchableHighlight onPress={() => setState('org')}>
<Image source={require('./assets/organization.png')} />
</TouchableHighlight>
<TouchableHighlight onPress={() => setState('notice')}>
<Image source={require('./assets/notification.png')} />
</TouchableHighlight>
<TouchableHighlight onPress={() => setState('profile')}>
<Image source={require('./assets/account.png')} />
</TouchableHighlight>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Navigation 의 Tab Navigation 으로 구현해 보세요.
https://reactnavigation.org/docs/tab-based-navigation/

아이콘의 경우, Expo 에서 제공하는 아이콘도 고려해 보세요.
https://docs.expo.io/guides/icons/


export default function App() {
const [logined, setLogin] = React.useState(true);
const loginCheck = () => {
AsyncStorage.getItem('username')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.expo.io/versions/v38.0.0/sdk/securestore/
SecureStore 도 고려해 보세요.

compo/loginview.js Outdated Show resolved Hide resolved
@sukso96100
Copy link
Contributor

sukso96100 commented Jul 22, 2020

제가 2~3년간 개발/유지보수해 온 React Native(Expo) 앱 입니다. 소스코드 참고해 보시면 많은 도움이 될겁니다.
https://github.com/s-owl/skhu-app

제가 커멘트 단 부분 한번 수정해 보시고 추가 커밋을 동일 브랜치(dev-onting) 에 푸시해 주시면 다시 검토하겠습니다.

Copy link
Contributor

@sukso96100 sukso96100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단은 승인해 드리겠습니다. 추후에 아래와 같은 부분을 작업해 보시기 바랍니다.

  • 메인화면 하단 바 React Navigation의 Tabbar 로 구현. 아이콘은 비트맵 이미지가 아닌 Expo 제공 벡터 아이콘 팩 활용
  • 로그인 성공 시 세션 값 SecureStore 에 저장
  • 로그인 성공하면 메인 화면으로 이동

https://docs.expo.io/guides/icons/
https://docs.expo.io/versions/latest/sdk/securestore/
https://reactnavigation.org/docs/hello-react-navigation
https://reactnavigation.org/docs/navigating
https://reactnavigation.org/docs/auth-flow
https://reactnavigation.org/docs/tab-based-navigation

@sukso96100 sukso96100 merged commit 868147e into master Jul 23, 2020
@onting onting deleted the dev-onting branch July 28, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants