fix: solana qa round #2704
Merged
fix: solana qa round #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
enesozturk
reviewed
Aug 16, 2024
| preflightCommitment: 'confirmed' | ||
| }) | ||
|
|
||
| // We should consider using `connection.confirmTransaction` instead of polling when websocket support is added |
There was a problem hiding this comment.
@zoruka Can we track this improvement with a Linear ticket?
enesozturk
reviewed
Aug 16, 2024
Comment on lines
+220
to
+223
| * We should consider serializing the transaction to base58 as it is the solana standard. | ||
| * But our specs requires base64 right now: | ||
| * https://docs.walletconnect.com/advanced/multichain/rpc-reference/solana-rpc#solana_signtransaction | ||
| */ |
There was a problem hiding this comment.
Same here for improvement ticket 🙏🏽
enesozturk
reviewed
Aug 16, 2024
|
|
||
| window?.localStorage.setItem(SolConstantsUtil.WALLET_ID, provider.name) | ||
| if (connectionChain) { | ||
| await this.switchNetwork( |
There was a problem hiding this comment.
Why do we do this? Would this be unexpected UX for the users? Is this have some bad cases (ie. like not having a chain provided)?
There was a problem hiding this comment.
Because the wallet may connect and nothing works because the wallet doesn't support the chain, it is the case of connecting with Trust Wallet and a couple other wallets that only supports mainnet. Then we are just switch to any of the supported chains or stop the connection.
enesozturk
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings somes fixes after a QA round of tests:
SolanaWriteContractTest;Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist