-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solana qa round #2704
fix: solana qa round #2704
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
♻️ Vite-Size ♻️Size Difference
Current Size
Base Size
|
preflightCommitment: 'confirmed' | ||
}) | ||
|
||
// We should consider using `connection.confirmTransaction` instead of polling when websocket support is added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoruka Can we track this improvement with a Linear ticket?
* We should consider serializing the transaction to base58 as it is the solana standard. | ||
* But our specs requires base64 right now: | ||
* https://docs.walletconnect.com/advanced/multichain/rpc-reference/solana-rpc#solana_signtransaction | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for improvement ticket 🙏🏽
|
||
window?.localStorage.setItem(SolConstantsUtil.WALLET_ID, provider.name) | ||
if (connectionChain) { | ||
await this.switchNetwork( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we do this? Would this be unexpected UX for the users? Is this have some bad cases (ie. like not having a chain provided)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the wallet may connect and nothing works because the wallet doesn't support the chain, it is the case of connecting with Trust Wallet and a couple other wallets that only supports mainnet. Then we are just switch to any of the supported chains or stop the connection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zoruka Left some comments
Description
This PR brings somes fixes after a QA round of tests:
SolanaWriteContractTest
;Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist