Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some wallets, a message saying
Failed to disconnect
appeared after clicking thedisconnect
button.This had 2 root causes:
Wallet does not implement
wallet_revokePermissions
(eg Phantom)Provider does not implement
emit
(eg when using Trust)Changed behavior so that we don't throw on revoke permissions, since it's not a required step.
Changed behavior to optionally call
emit
if availableBrought ethers5 up to speed on disconnect flow as revokePermissions was never implemented there
Type of change
Associated Issues
For Linear issues: Closes APKT-848
Checklist