chore: add clientId to BlockchainAPI requests #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… state variable to blockchain api controller and add handler to scaffold
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
glitch-txs
reviewed
Jul 9, 2024
| @@ -32,6 +32,7 @@ import type { | |||
| BlockchainApiRegisterNameParams | |||
| } from '../utils/TypeUtil.js' | |||
| import { OptionsController } from './OptionsController.js' | |||
| import { proxy } from 'valtio' | |||
There was a problem hiding this comment.
all core imports should be from valtio/vanilla to avoid react as required dep
enesozturk
reviewed
Jul 10, 2024
arein
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
clientIdquery parameter to blockchain API requests when connecting via the WC relay.Type of change
Associated Issues
Closes APKT-672
Checklist