Add Wallet Standard to AppKit + Solana #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…letConnect/web3modal into feat/wallet-standard-adapter
enesozturk
reviewed
Jul 2, 2024
enesozturk
reviewed
Jul 2, 2024
packages/solana/src/client.ts
Outdated
| @@ -330,9 +318,13 @@ export class Web3Modal extends Web3ModalScaffold { | |||
| return SolStoreUtil.state.connection | |||
| } | |||
|
|
|||
| public async checkActiveProviders() { | |||
| public async checkActiveProviders(standardAdapter?: StandardWalletAdapter[]) { | |||
There was a problem hiding this comment.
Maybe a plural name?
Suggested change
| public async checkActiveProviders(standardAdapter?: StandardWalletAdapter[]) { | |
| public async checkActiveProviders(standardAdapters?: StandardWalletAdapter[]) { |
enesozturk
reviewed
Jul 2, 2024
packages/solana/src/client.ts
Outdated
| const wallet = walletId?.split('_')[1] | ||
| const adapter = this.walletAdapters.find(a => a.name.toLocaleLowerCase() === wallet) | ||
| if (adapter && wallet && window[wallet as keyof Window]) { | ||
| const walletArray = walletId?.split('_') ?? '' |
There was a problem hiding this comment.
Split returns an array of strings while the default value is '' after nullish operator. Shouldn't it []
There was a problem hiding this comment.
yep, I was being lazy, but ''[0] is same as [][0]
phoenixVS
approved these changes
Jul 9, 2024
| adapter => adapter.name.toLocaleLowerCase() === providerType.toLocaleLowerCase() | ||
| ) | ||
| ?.publicKey?.toString() | ||
| if (chain) { |
There was a problem hiding this comment.
Here it is used in SolStoreUtil, which does not rewrite this.chain, and stores data about chainId, explorer, etc.
while, as I understood this.chain tells 'EVM' or 'solana' in use. Probably we should rename it to "mode"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
N/A
Changes
Associated Issues
closes #2469