Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wcPromise issue in old project setups #2481

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix wcPromise issue in old project setups #2481

merged 2 commits into from
Jul 1, 2024

Conversation

glitch-txs
Copy link
Member

Breaking Changes

N/A

Changes

  • feat:
  • fix: Change WalletConnect connection promise logic to support old project environments.
  • chore:

Associated Issues

closes #...

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 1, 2024 11:13am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 1, 2024 11:13am

Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wondering why this promise pattern was used in the first place. Seems like it was configuring some things related to images before awaiting the promise.
Are you sure this doesn't impact other flows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants