refactor: handle balance and balanceSymbol fetch to update w3m-button #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tomiir
reviewed
Jun 17, 2024
packages/scaffold/src/partials/w3m-account-default-widget/index.ts
Outdated
Show resolved
Hide resolved
tomiir
reviewed
Jun 18, 2024
packages/scaffold/src/partials/w3m-account-default-widget/index.ts
Outdated
Show resolved
Hide resolved
tomiir
approved these changes
Jun 18, 2024
tomiir
reviewed
Jul 10, 2024
| @@ -264,7 +264,7 @@ export class W3mAccountDefaultWidget extends LitElement { | |||
| await ConnectionController.disconnect() | |||
| EventsController.sendEvent({ type: 'track', event: 'DISCONNECT_SUCCESS' }) | |||
| ModalController.close() | |||
| } catch { | |||
| } catch () { | |||
35e8931
to
ba371b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
We are rendering button as soon as we connected but we fetch the balance async. This creates a glitch in the button UI that the UI is changing a bit. This PR introduces changes to update the rendering business logic a bit to handle balances in loading time.
Changes
Associated Issues
closes #...