Housecleaning #95
Merged
Housecleaning #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting deeper into code and cleaning as I go. Prior to this build,
locally I had 5 test cases with ignore. All seem consistently working
now.
Updating dependencies
Updating legacy ${basedir} to ${project.basedir} in maven poms
Fixing formatting where spaces used instead of standard tabs in this
project
Sync tomcat code bases as best possible
Updating jetty piece to use consistent dependencies (ie it had servlet
2.5 but jetty version expected newer, etc)
Requires java 7.
fixed embedded jetty. It had servlet/jsp conflicts with old version. Requiring java 7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting deeper into code and cleaning as I go. Prior to this build,
locally I had 5 test cases with ignore. All seem consistently working
now. This batch doesn't appear to have done anything that would have fixed it but consistent runs are good. No ignores anywhere in code base now on unit tests.
Updating dependencies
Updating legacy ${basedir} to ${project.basedir} in maven poms
Fixing formatting where spaces used instead of standard tabs in this project
Sync tomcat code bases as best possible
Updating jetty piece to use consistent dependencies (ie it had servlet
2.5 but jetty version expected newer, etc)