Format changes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to get proper formatting set.
|
It looks ok, I'll merge it, but this branch is being abandoned. Don't worry about formatting too much moving forward, it will eventually clean itself all up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get proper formatting set.
I reformatted everything in eclipse which included standard cleanup. I'm not sure this will properly take as expected but unable to determine that from this end. Can you spot check some files to see if they look correct? If you can merge just one in that changed then open in eclipse with spacing shown, it should show a little square at the end of each line. There doesn't seem to be any settings in github gui that would even remotely affect this. From eclipse, I know my project is 100% ok at the moment...