Tomcat7 #6
Tomcat7 #6
Conversation
Full source based dropped in place. Please note that differences are in line breaks. It appears that both eclipse and git hub gui will remove formats for line break that show as squigly square. Other than that, code is the same in most locations. Also, tomcat base updated from 7.0.4 to 7.0.29. Some methods were removed as they were deprectated. Others were retained due to usage currently.
three more files that missed the first commit.
|
Merged this, thank you. I want the update on the 1.5 branch too please. |
|
Thanks! I'll get this all updated on 1.5 branch as soon as I can. Probably later this week or at latest sometime this weekend. I had a few other things to update in the meantime... Thanks, Jeremy -----Original Message----- Merged this, thank you. I want the update on the 1.5 branch too please. Reply to this email directly or view it on GitHub: No virus found in this message. |
|
Jeremy, can you please, please figure out how to preserve the line endings and not have giant changes of whitespaces for the next pull? I would start with Eclipse and making sure you're using defaults, then with Git that has options to update CR/LFs, it should be off. Practice on a throw-away branch of your own code. Thaanks :) |
|
Sure. I have tracked it down to github gui doing it on the confirm. I can see my original source is correct and diffs in github gui look correct. As soon as I commit it does this. I haven't found where those settings are yet in github. Ill look more in depth tonight. This issue is important. I'm trying to work other projects and having same issue. As soon as I figure it out would you like me to fix all the files currently messed up? Sent from my Verizon Wireless Phone --- Original Message --- From: "Daniel Doubrovkine (dB.)" [email protected] Jeremy, can you please, please figure out how to preserve the line endings and not have giant changes of whitespaces for the next pull? I would start with Eclipse and making sure you're using defaults, then with Git that has options to update CR/LFs, it should be off. Practice on a throw-away branch of your own code. Thaanks :) Reply to this email directly or view it on GitHub: |
|
I wouldn't worry too much about the past, up to you. |
fixed pull request against tomcat7 version.