Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine API, core, mock, servlet, and jass into single jar file #26

Merged
merged 2 commits into from
Aug 22, 2012
Merged

Combine API, core, mock, servlet, and jass into single jar file #26

merged 2 commits into from
Aug 22, 2012

Conversation

ryantxu
Copy link
Contributor

@ryantxu ryantxu commented Aug 22, 2012

I think a single small .jar that does all the normal things is the easier to approach then a pile of small ones.

This patch puts the 'mock' package in the runtime deployment -- this is not great, but I (personally) don't think it is a big deal

@dblock dblock merged commit fb4ed40 into Waffle:1.5 Aug 22, 2012
@dblock
Copy link
Collaborator

dblock commented Aug 22, 2012

Ok. I merged this. Coffee was helpful to reflect on the issue. Users win.

Note that I had to move the WaffleInfo class, I think it was leftover in core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants