Remove Servlet API 3 specific code #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,12 +69,15 @@ public void testImpersonateEnabled() throws IOException, ServletException { | |||
| Advapi32Util.getUserName().equals( | |||
| MockWindowsAccount.TEST_USER_NAME)); | |||
| SimpleHttpRequest request = new SimpleHttpRequest(); | |||
|
|
|||
| //SimpleHttpRequest request = new SimpleHttpRequest(); | |||
There was a problem hiding this comment.
Take the habit of deleting code. This was clearly my mistake. Don't worry about this one - removing it in merge.
|
Merging, thanks much for this. The mockito implementation is particularly nice. |
|
Thanks! Yes, Mockito makes writing tests much easier and (I think) cleaner. Also lets us avoid the hairy implementation details for things like servlet 2.5 vs 3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should avoid the complication of supporting Servlet API 3 explicitly since we are not using anything special in it.
This branch removes it, and moves the waffle-http class into waffle-mock
See discussion at:
https://groups.google.com/forum/?fromgroups=#!topic/waffle-users/ocBGxKC55aI