Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed clean ant script
Fixed 3 bugs that showed up from most resent build. Not sure what
happened.
Daniel,
I guess you got rid of 1.5-ivy version...anyway fixed the ant piece for clean build. The taskdef for emma just needed to be wrapped. I couldn't run this for a few reasons. Three files had issues. Two of them appeared to not have the original changes and another had some issue with a merge. Not sure if that was cause I did something exactly when you were or what occurred. Maybe it occurred when getting rid of 1.5-ivy branch? Anyway, 4 files here. If you need me to rebase against 1.5 and try again I can do so. I also couldn't run the git commands in the ant script so I was unable to run a full build. However, that is probably mute since this fix corrects deleting everything without error.
I do have additional things after this all gets sync'd. I ran both findbugs / pmd against the project. This pointed out a number of items such as boolean getters needed to be is* instead. Would that be a breaking change to fix those? Majority of other issues were all in unit tests. PMD made lots of suggestions to change test cases and led me to figure out all test cases are really version 3 junit so in the next set, I have them all converted fully to junit 4. Everything is working there but I'm sure it will take me a bit to rebase and get everything in working order.
Thanks,
Jeremy