Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetty Subproject #15

Closed
wants to merge 5 commits into from
Closed

Add Jetty Subproject #15

wants to merge 5 commits into from

Conversation

ryantxu
Copy link
Contributor

@ryantxu ryantxu commented Aug 8, 2012

This adds the libraries and a simple launcher to run waffle within jetty

Coming soon... a jetty Authenticator and LoginService based on waffle

ant failed for missing files folders.
this avoids warning when running with jdk 7
This lets you get the version information with
getPackage().getImplemenationXXX()
An XML document that shows waffle system setup
@dblock
Copy link
Collaborator

dblock commented Aug 11, 2012

On Jetty, I thought it was a simple servlet-compatible container. Do we need to do anything special for it (Authenticator, etc.)?

@ryantxu
Copy link
Contributor Author

ryantxu commented Aug 11, 2012

eep -- i clearly still have a lot to learn with git/github. I tried to make #15 only point to the changes here:
https://github.com/ryantxu/waffle/commit/b375306cc56261d850d568a91ac888a457fc7b05

Not all the changes -- I guess I need to make a pull request from a fresh checkout.


Yes, Jetty is a simple servlet container. Like tomcat if you use the ServletFilter, there is nothing special to do. Like tomcat it also has its own Authenticator classes.

The stuff I added here is really just a trivial starting place. The only real thing is a utility class that lets you run the server from a command line or directly within eclipse.

https://github.com/ryantxu/waffle/blob/b375306cc56261d850d568a91ac888a457fc7b05/Source/JNA/waffle-jetty/src-test/waffle/jetty/StartEmbeddedJetty.java

It may not make sense to merge this 'till there is anything specifically jetty related, but I personally find running a webserver in debug mode very helpful.

@dblock
Copy link
Collaborator

dblock commented Aug 15, 2012

Having a web server that developers can run in debug mode would be helpful. Please re-add Jetty via ivy (the new way to fetch dependencies), and make sure to document what one is supposed to do with this. README is probably OK.

I'm going to close this for now, but a nice small clean PR is welcome.

@dblock dblock closed this Aug 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants