Added toString method to allow user to be logged in Tomcat #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a test and an entry in CHANGELOG, please. |
|
This is done, please let me know if I need to change anything else. Thanks |
|
Looks good, thanks. |
dblock
added a commit
that referenced
this pull request
Aug 28, 2014
Added toString method to allow user to be logged in Tomcat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the NegotiateSecurityFilter, the logged in user cannot be logged in Tomcat using the (Extended)AccessLogValve. There are a couple of objects in the session that could be logged (but not remote user, it is only available in the wrapped request), if they exposed a toString method. This adds a toString method to WindowsPrincipal, so that the authenticated user can be logged with x-S(waffle.servlet.NegotiateSecurityFilter.PRINCIPAL) using the ExtendedAccessLogValve or %{waffle.servlet.NegotiateSecurityFilter.PRINCIPAL}s using the AccessLogValve.