Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Code Quality Changes #127

Merged
merged 7 commits into from
Aug 6, 2014
Merged

More Code Quality Changes #127

merged 7 commits into from
Aug 6, 2014

Conversation

hazendaz
Copy link
Member

@hazendaz hazendaz commented Aug 3, 2014

Major points

  1. ENUM using correct case but implemented underlying code to allow external setup to still be lower case. This required internal upper casing for all that use it and for some additional getter/setters for spring. If we decide to make a breaking change later to remove this internal adjustments, it should be left for waffle 2.
  2. Use guava joiner rather than stringBuilder where comma delimited items were being created.

@hazendaz
waffle parent cleanup
ea34492 
Stop tracking needless items on site page that are part of wagon as
these will not be used.
Updated pmd plugin and stop tracking underlying pieces.  While used in
this case, not worth the effort.
@hazendaz
turn on tomcat tests
62d1888 
turned on previously missed tests with annotation.  added todo since
part of it didn't work correctly.
@hazendaz
Added package info
bc83f89 
per java standards, added package info.
@hazendaz
Final Modifiers & Light Cleanup
db4306d 
Added final modifiers
Use of statics where needed
Name additional _ instance variables appropriately
Use value on setters so fields are not hidden
Use new* on constructors so fields are not hidden
Fix hidden fields by renaming
Added @deprecated where appropriate
Removed unnecessary throws
Logger cleanup
Correct waffleInfo to not use classes affecting jvm.
@hazendaz
Use Joiner rather than stringBuilder
8b9e5a7 
Use guava joiner rather than stringBuilder.  It is much cleaner.
Light cleanup using final modifier
@hazendaz
ENUM naming
1eab72e 
Properly name ENUMS
Other light cleanup - joiner / final modifier.
@hazendaz
For ENUM - uppercase principal and role
1feb968 
Uppercase getting values of enum so that callers don't need to change
anything.  This is for internal usage only and works for all.  Required
use of upper casing input values to match internals.  Spring 2 required
getters and setters to do this.  Spring 3/4 required setters.
dblock added a commit that referenced this pull request Aug 6, 2014
@dblock
Merge pull request #127 from hazendaz/master
0526b6f 
More Code Quality Changes
@dblock dblock merged commit 0526b6f into Waffle:master Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hazendaz @dblock