More Quality Cleanup #126
More Quality Cleanup #126
Conversation
* use explicit reference such as this or static references * use proper java variable instance naming (ie not underscores preceding name) * use proper java case on static final variables such as LOGGER * removed unnecessary definitions of remoteHost, remoteAddr, and remotePort shadowed from tomcat super classes under test cases. Renamed session to httpSession as that shadow was separate and needed to be defined separately. * updated tomcat 7 to 7.0.55 * started adding comments in tomcat 8 and will follow in others regarding pieces of tomcat not actually implemented within test cases in an effort to make it more obvious to what is being used. Ultimately will like pull unimplemented items out into separate class making the waffle implemented portion completely obvious.
|
This is very nice, good work. As a small recommendation I suggest making small commits for each one of the line items as you go along. This way the history is preserved in git and not just in PRs. |
|
Sure. I will adjust my strategy. That makes a lot of sense. I had a feeling this was getting a little overwhelming and hard to follow. I’ll definitely make sure to use smaller commits. Thanks, Jeremy From: Daniel Doubrovkine (dB.) @dblockdotorg [mailto:[email protected]] This is very nice, good work. As a small recommendation I suggest making small commits for each one of the line items as you go along. This way the history is preserved in git and not just in PRs. — |
name)
remotePort shadowed from tomcat super classes under test cases. Renamed
session to httpSession as that shadow was separate and needed to be
defined separately.
regarding pieces of tomcat not actually implemented within test cases in
an effort to make it more obvious to what is being used. Ultimately
will like pull unimplemented items out into separate class making the
waffle implemented portion completely obvious.