Guava Base64 Encoding, Joiner, and sonar cleanup #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated older Base64 originating from older security libraries in favor if just using guava version. No calls to now deprecated class/methods in code base but since it was public, marked it deprecated for removal in waffle 1.8. Change internals to just wrap guava version so older license information code be removed. Now entire library is just waffle or donated on git original. Applied usage of guava joiner for cleaner getConnectionId of NtlmServletRequest. Started cleanup in variable/property naming in some classes before discovering base64 could be replaced and guava joiner add so retained the changes.
|
You can just kill the Base64 wrapper if you want, this was never meant to be an external interface and I doubt anyone cares. |
dblock
added a commit
that referenced
this pull request
Jul 28, 2014
Guava Base64 Encoding, Joiner, and sonar cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated older Base64 originating from older security libraries in
favor if just using guava version. No calls to now deprecated
class/methods in code base but since it was public, marked it deprecated
for removal in waffle 1.8. Change internals to just wrap guava version
so older license information code be removed. Now entire library is
just waffle or donated on git original.
Applied usage of guava joiner for cleaner getConnectionId of
NtlmServletRequest.
Started cleanup in variable/property naming in some classes before
discovering base64 could be replaced and guava joiner add so retained
the changes.