1.5 #12
Closed
1.5 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, preparing to merge tomcat 7 and spring security 2 parts.
Since servlet 2.5 was provided separate from tomcat instances, I have added a 3.0 version which is on par with tomcat 7.
spring security 3 didn't use this so assumed to not be needed here either. Tests worked without it.
tomcat 5 and 7 contained this so added it.
Some master tests were missing as a result of early breakup of code so added them for consistancy. They really were not necessary as eclipse can run all tests by selecting package but this helps.
Supporting code changes for latest 3rd party software. Format changes to enforce same look throughout. Updated older license information to latest showing github address and copyright. Added additional commons logging to slf4j conversions. Cleaned up lots of warnings for generics.
Servlet 2.5 spec and 3.0 spec are in same directory thus need to access them directly
added servlet3, and aligned tomcat 5 & 7
deleted duplicate servlet test files under spring. They use direct servlet copies.
test suites call underlying tests cases so running from ant will result in all being called twice. This fixes the issue.
This reverts commit d6d07474704b93e54731b5b21d81f4ebc6e74968.
addressed bug # 9.
Changed <?> items to correct generic such as string and cleaned up casting issue in spring 3 using generics instead.
Replaced inclusion of third party jars for all but JNA and Tomcat 5.5.35 in favor of using Ivy for dependency management. Also added http3 to be syntactically correct in uses of servlet 3.0 spec.
Third party items now controlled with ivy thus no longer attached to project directly except where needed.
On my machine some tests dont work as a result full build fails. I accidently uploaded this check turned off so this restores it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third Party now utilizes ivy for dependency management. Large count here is removal of previous storing of various 3rd party products.
JNA retained in two places (3.4.0 under ivy and 3.4.2 under thirdparty using ivy type layout). The later is used in the project. The purpose is to allow licenses to be populated through ivy reports.
Tomcat 5.5.35 is not on ivy/maven. Last version was 5.5.23. Therefore same scenario as jna.
Minor cleanup in tomcat 5 as it had bits and pieces of tomcat 6 which were unnecessary.
Pointing spring 3 and tomcat 7 to servlet3.
Added http3 as it pretty much is expected if using servlet3. Now pointing spring3 to http3.
Classpaths in eclipse reduced to only use what is required per project piece.
Added some additional generics usage throughout which makes compilation checks rather than run time checks as it was using casts.
Github ignores added for ThirdParty/_lib and ThirdParty/_report.
Master build will ensure third party is present and will need run when first working with this project. Can run build.xml under ThirdParty to get the same.
Ivy will need added manually to Ant in eclipse. If running separate from eclipse, I believe it needs an IVY_HOME variable but have not confirmed.
http:https://ant.apache.org/ivy/
Fixed bug # 9 regarding multiple test runs. This was due to additional of test suites that were kicked off when all tests were run. Simply ignoring those now in ant runs.
This time around I have tested a great deal in ensuring builds are working without issues. Only issue I personally continue to have is that a few of the test cases simply do not work for me. I am having issues with WindowsAuthProviderTests and 2 ImpresonationTests.