Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed path to jar files so that build.cmd all works #10

Closed
wants to merge 6 commits into from
Closed

fixed path to jar files so that build.cmd all works #10

wants to merge 6 commits into from

Conversation

ryantxu
Copy link
Contributor

@ryantxu ryantxu commented Aug 3, 2012

No description provided.

rather then writing Version: ${waffle.version}, write "Implementaion
Version"

This lets us use:

getPackage().getImplementationVersion()

to read the version information
this avoids compiler warnings when running from java 1.6 or 1.7
Add the ability to run samples direclty from eclipse.  Just run:
StartEmbeddedJetty.java
Adding a utility to collect all system information into an XML document
Adds a servlet to return this information
(sorry, the web.xml was added in the previous commit)
@ryantxu
Copy link
Contributor Author

ryantxu commented Aug 7, 2012

I'm still learning how to use git/github, so forgive me if I have made things complicated (and let me know how to make things easier)

I added a utility class to help debug the environments I am still struggling to get working. Long term it would be great to have a simple servlet that can check all the standard things and report back. This is a first step in that direction.

This uses the builtin javax.xml package to build an XML document. This avoids the need for another dependency, but has a really ugly API

@dblock
Copy link
Collaborator

dblock commented Aug 7, 2012

First, thanks for the pull.

There's a lot of other stuff here that's nothing to do with fixing paths. There's a Jetty server?

At this point master is finished, we're working on the 1.5 branch that has a ton of changes. We should have made master the next release and tagged the previous one, but this is the way it is for now :) Please check that branch, the build.cmd should be all good. Plus the documentation is now in markdown and there's a section on contributing that talks about setting up a development environment.

Looking forward to your PRs into 1.5 and beyond. Thanks.

@dblock dblock closed this Aug 7, 2012
@ryantxu
Copy link
Contributor Author

ryantxu commented Aug 7, 2012

Sorry, this was really two requests (and one trivial one) and not yet understanding github

  1. Include embedded Jetty for easy inline testing
  2. Adding a utility class to collect info debugging

I'll start over off the 1.5 branch and try to make two pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants