-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely mavenize build #79
Comments
I am not against Maven-izing the Java side of this project, however I want to make sure it really makes things simpler rather than more complicated. Happy to review any solid PR. Also, cc-ing @skamille who loves Maven these days :) |
Maven - My first thoughts.
a. I did put a request out to the apache tomcat dev group. I’m not holding my breath on this one. b. With maven, there is no point to ivy or keeping dependencies this way. Everything will be pulled down properly on maven builds to .m2/repository under user account.
a. src/main/java b. src/main/resources c. src/test/java d. src/test/resources
a. mvn clean install b. mvn site
a. Project Information
b. Reports (We want reports / we got em’)
Sneak peak with the twitter bootstrap :) From: Daniel Doubrovkine (dB.) @dblockdotorg [mailto:[email protected]] I am not against Maven-izing the Java side of this project, however I want to make sure it really makes things simpler rather than more complicated. Happy to review any solid PR. Also, cc-ing @skamille https://github.com/skamille who loves Maven these days :) — |
Tomcat 5 support can be removed. Looking forward to a PR. |
I thought my image would have shown up of the site page. Guess not! I was thinking to just mavenize this fully before dropping tomcat 5. Doesn't matter either way. Essentially, fully mavenizing this isn't that big of a deal as it was mostly done. I've just added bells and whistles. I expect to have a PR on this later this week. |
I'll keep existing folder structure on the first move over to maven to keep the changes down to a minimum. |
OK - after merging the first cut with ant/ivy removed and cleanup for more support within parent pom. I am at two additional points.
|
For anything Maven related you can just go ahead. I am a noob when it comes to Maven, trust you to do the right thing :) |
Don't forget to update https://github.com/dblock/waffle/blob/master/Docs/SettingUpDevelopmentEnvironment.md. I'll play with the results on my side. |
Sure. If you run into any issues just let me know. Im pretty good with maven. Year plus solid use of it. Ill be out of town this next weekend but other than that I will be on this until everything is good including all documentation. --- Original Message --- From: "Daniel Doubrovkine (dB.) @dblockdotorg" [email protected] Don't forget to update https://github.com/dblock/waffle/blob/master/Docs/SettingUpDevelopmentEnvironment.md. I'll play with the results on my side. Reply to this email directly or view it on GitHub: |
Layout is now using standard maven layout. Some tests were updated / fixed in this build. I still owe updating of documents before this can be called complete. |
This task should be complete at this point. I'll review again the documentation in the coming days. Let me know if everything looks in order and if you are able to perform builds successfully. I believe there were some older comments in some of the documents regarding building zip deployments. If that rings any bells as something that might be missing, let me know and I can take a look at getting what is missing. If that is from prior to the first early goes a long while back for maven, then I can likewise clean up the documentation to remove that information. |
Nice work @hazendaz! I am super happy to see people take real ownership of this project, I haven't been living in the Windows world for a while :) |
I see that this project has made great strides towards maven but still uses quite a bit of ant. Is the vision to completely move to maven? I'm willing to help out in that area. If so, I'll start looking at doing so.
The text was updated successfully, but these errors were encountered: