-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom instances of GenericPrincipal in WaffleAuthenticatorBase subclasses #561
Comments
Snap252
pushed a commit
to Snap252/waffle
that referenced
this issue
Nov 15, 2017
hazendaz
pushed a commit
that referenced
this issue
Dec 3, 2017
* Custom instances of GenericPrincipal in WaffleAuthenticatorBase subclasses #561 * #571 * #571 (comment) #571 +- replaced double space by single space * #571 + test case for custom principal * #571 Custom instances of GenericPrincipal in WaffleAuthenticatorBase #571 @Snap252 Can you add the same test case to tomcat7,8,9? Spring has now released spring security 5 so now just wating on that piece from you to merge this then a few rounds of testing and this will be released. Thanks.
This has been applied on master. Closing. Release of 1.9.0 will be out in next week or so. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Module wffle-tomcat85:
waffle.apache.MixedAuthenticator and waffle.apache.NegotiateAuthenticator should both give the possibility to create other instances of Principal (e.g. for role detection) by extracting a protected method.
waffle.apache.NegotiateAuthenticator.authenticate(Request, HttpServletResponse)
:with extracted overridable method
for me I just need the framework to detect the current user name (no windows roles etc is needed) - the roles have to be detected by a further sql query inside the custom subclass of
GenericPrincipal
.Due to the problem that this method is currently inlined, I have to copy a full class to make these changes.
The text was updated successfully, but these errors were encountered: