Improve performance when roleFormat == none

[ehestigoni]

Hi all,
I've noticed that when roleFormat is set to 'none' waffle fetches the user groups through windowsIdentity.getGroups() but the info is not used anywhere.

In a system with a domain controller, the getGroups task can be very expensive.

Should we getGroups only when roleFormat is different from 'none'?

[hazendaz]

@ehestigoni Can you point to where that is in the code for quick reference here?

[ehestigoni]

Sure.

waffle/Source/JNA/waffle-tomcat9/src/main/java/waffle/apache/GenericWindowsPrincipal.java

Line 61 in cfe5bc7

this.groups = GenericWindowsPrincipal.getGroups(windowsIdentity.getGroups());

waffle/Source/JNA/waffle-tomcat9/src/main/java/waffle/apache/GenericWindowsPrincipal.java

Line 79 in cfe5bc7

for (final IWindowsAccount group : windowsIdentity.getGroups()) {

[ehestigoni]

@hazendaz (Just in case you did not get buzz from the post above).
Cheers.

[hazendaz]

Got it thanks Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Eduardo <[email protected]> Sent: Sunday, September 24, 2017 10:09:16 PM To: Waffle/waffle Cc: Jeremy Landis; Mention Subject: Re: [Waffle/waffle] Improve performance when roleFormat == none (#552) @hazendaz<https://github.com/hazendaz> (Just in case you did not get buzz from the post above). Cheers. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#552 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho51-5XumhgroaFBdosxVqb2hW6Gyks5slwtMgaJpZM4PdTXn>.

[hazendaz]

@dblock Does this issues ring any bells for you?