Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old branches #134

Closed
hazendaz opened this issue Aug 24, 2014 · 5 comments
Closed

Drop old branches #134

hazendaz opened this issue Aug 24, 2014 · 5 comments
Labels

Comments

@hazendaz
Copy link
Member

I've reviewed all the old branches on waffle currently. All could be deleted with exception of the one trying to solve issue #59. I realize most of these came originally from the old codeplex site but there really is no mirror over there any longer since this is only being worked on github. So I propose that we drop all those old branches that are no longer necessary. There is no code in those that isn't already on the current code base with exception of the #59 that may or may not still be needed depending on outcome of further investigation there. I can certainly remove the old branches provided the go-ahead is given.

@hazendaz hazendaz added the chore label Aug 24, 2014
@dblock
Copy link
Collaborator

dblock commented Aug 24, 2014

We used to have branches for various versions of thirdparty servers before Waffle was combined 1.5. The only reason to keep those would be to preserve the history, but it has been 2 years, so maybe it's time, go for it.

@hazendaz
Copy link
Member Author

Was the history not pulled into the master when those became part of the master? It seems they were based on indications that they are all around 1 commit in difference. That 1 commit usually was some marker noting the old codeplex location. So seems the history is on the master but maybe it wasn’t. If it was on the master, then it will still be there from what I understand.

From: Daniel Doubrovkine (dB.) @dblockdotorg [mailto:[email protected]]
Sent: Sunday, August 24, 2014 7:32 PM
To: dblock/waffle
Cc: Jeremy Landis
Subject: Re: [waffle] Drop old branches (#134)

We used to have branches for various versions of thirdparty servers before Waffle was combined 1.5. The only reason to keep those would be to preserve the history, but it has been 2 years, so maybe it's time, go for it.


Reply to this email directly or view it on GitHub #134 (comment) . https://github.com/notifications/beacon/975267__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNDU0MjMwMCwiZGF0YSI6eyJpZCI6NDA1MjU0NTB9fQ==--3c3bf65270d15bb399a7e36f949ed8d29ed382d5.gif

@dblock
Copy link
Collaborator

dblock commented Aug 24, 2014

I think you are right, those branches did get merged with history around 1.5. Again, just kill everything you don't think is necessary.

@hazendaz
Copy link
Member Author

Great! Thanks.

From: Daniel Doubrovkine (dB.) @dblockdotorg [mailto:[email protected]]
Sent: Sunday, August 24, 2014 7:36 PM
To: dblock/waffle
Cc: Jeremy Landis
Subject: Re: [waffle] Drop old branches (#134)

I think you are right, those branches did get merged with history around 1.5. Again, just kill everything you don't think is necessary.


Reply to this email directly or view it on GitHub #134 (comment) . https://github.com/notifications/beacon/975267__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNDU0MjU2NSwiZGF0YSI6eyJpZCI6NDA1MjU0NTB9fQ==--c2ea3072cbde5afb53d566c5e87a8774c9817196.gif

@hazendaz
Copy link
Member Author

Removed old branches that were merged into master over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants