-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET implementation uses fixed buffer size #114
Labels
Comments
@kentcb Is it possible that you can do a pull request for this? I see where i think the issue is and understand what you need fixed, however, I'm not a .net developer nor have anything setup to run tests verifying the fix so need a little help. |
@hazendaz yes, I plan on doing this once I return to Australia later this week. |
kentcb
added a commit
to kentcb/waffle
that referenced
this issue
Jul 29, 2014
Where relevant, tokens are obtained in a loop with an increasing buffer size as long as SEC_E_BUFFER_TOO_SMALL or SEC_E_INSUFFICIENT_MEMORY is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The .NET implementation uses a buffer size specified by
Secur32.MAX_TOKEN_SIZE
, which is currently set to 12KB. For tokens that exceed this size, an exception is raised:A similar issue in the Java implementation was fixed around a year ago (see ebedaf7). The .NET implementation should take the same approach.
The text was updated successfully, but these errors were encountered: