Upgrade Guava to 17.0

[jcgarciam]

Was: JEE7 server chokes when including waffle-jna 1.6 due to Guava issue 1433

I'm trying to use Waffle inside glassfish, but it chokes with :

[glassfish 4.0] [SEVERE] [] [javax.enterprise.system.core] [tid: _ThreadID=34 _ThreadName=admin-listener(2)] [timeMillis: 1369346915664] [levelValue: 1000] [[
Exception while loading the app : CDI deployment failure:WELD-001408 Unsatisfied dependencies for type [Set] with qualifiers [@default] at injection point [[BackedAnnotatedParameter] Parameter 1 of [BackedAnnotatedConstructor] @Inject com.google.common.util.concurrent.ServiceManager(Set)]
org.jboss.weld.exceptions.DeploymentException: WELD-001408 Unsatisfied dependencies for type [Set] with qualifiers [@default] at injection point [[BackedAnnotatedParameter] Parameter 1 of [BackedAnnotatedConstructor] @Inject com.google.common.util.concurrent.ServiceManager(Set)]

The problem lies on google guava being discussed here:
https://code.google.com/p/guava-libraries/issues/detail?id=1433

My workaround was to revert back to guava 13.0.1

ie:

        <dependency>
            <groupId>com.github.dblock.waffle</groupId>
            <artifactId>waffle-jna</artifactId>
            <version>1.6</version>
            <exclusions>
                <exclusion>
                    <groupId>com.google.guava</groupId>
                    <artifactId>guava</artifactId>
                </exclusion>
            </exclusions>
        </dependency>
        <dependency>
            <groupId>com.google.guava</groupId>
            <artifactId>guava</artifactId>
            <version>13.0.1</version>
        </dependency>

Do you see any issue by downgrading the guava version?

[hazendaz]

It is safe to downgrade without issue. You can also upgrade to the latest without issue to. The latest is 17.0.

[dblock]

There're no issues with using either version of Guava.

I would welcome it if you could upgrade Waffle to use 17.0, please contribute!

[jcgarciam]

I reviewed the pom.xml for the master/Source/JNA/waffle-jna/pom.xml and it does have

<guava.version>17.0</guava.version>

However it seems you should release a new version (probably 1.6.1) to the public maven repository since it has:

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>14.0.1</version>
</dependency>

here:
https://search.maven.org/remotecontent?filepath=com/github/dblock/waffle/waffle-jna/1.6/waffle-jna-1.6.pom

[hazendaz]

Yes 1.7 version of waffle will use guava 17.0. However 13.0.1 works too. Not sure when 1.7 waffle will be released. No real rush.

--- Original Message ---

From: "Juan C. Garcia M." [email protected]
Sent: June 24, 2014 8:56 AM
To: "dblock/waffle" [email protected]
Cc: "Jeremy Landis" [email protected]
Subject: Re: [waffle] Upgrade Guava to 17.0 (#100)

I reviewed the pom.xml for the master/Source/JNA/waffle-jna/pom.xml and it does have

<guava.version>17.0</guava.version>

However it seems you should release a new version (probably 1.6.1) to the public maven repository since it has:

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>14.0.1</version>
</dependency>

here:
https://search.maven.org/remotecontent?filepath=com/github/dblock/waffle/waffle-jna/1.6/waffle-jna-1.6.pom

---

Reply to this email directly or view it on GitHub:
#100 (comment)

[dblock]

@hazendaz Can we close this?

I think there's a decent changelog now for 1.7, feel free to make a release!

[hazendaz]

I was thinking same thing. I'm out of town right now. I can do this next weekend.

--- Original Message ---

From: "Daniel Doubrovkine (dB.) @dblockdotorg" [email protected]
Sent: June 29, 2014 8:58 AM
To: "dblock/waffle" [email protected]
Cc: "Jeremy Landis" [email protected]
Subject: Re: [waffle] Upgrade Guava to 17.0 (#100)

@hazendaz Can we close this?

I think there's a decent changelog now for 1.7, feel free to make a release!

---

Reply to this email directly or view it on GitHub:
#100 (comment)

[hazendaz]

Closing this request. Version 1.7 has guava updated and should be released within the week.