Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 4.1.5 #46

Merged
merged 3 commits into from
Mar 29, 2020
Merged

Merge 4.1.5 #46

merged 3 commits into from
Mar 29, 2020

Commits on Mar 10, 2020

  1. bug fix: NoahMP STEPWTD==0, divide by zero (wrf-model#1129)

    TYPE: bug fix
    
    KEYWORDS: NoahMP, opt_run option
    
    SOURCE: internal
    
    DESCRIPTION OF CHANGES:
    Problem:
    When running the NoahMP scheme with the ground water option (opt_run=5), the STEPWTD
    variable is initialized to a non-zero value. However when opt_run!=5, then the STEPWTD
    variable remains an uninitialized zero value. In the WRF source code, there are a couple of
    places where mod(x,STEPWTD) occurs. This causes an immediate "divide by zero" error in
    the first call to the surface driver.
    
    Solution:
    The IF test logic is re-arranged so that only when opt_run=5 (which means that STEPWTD
    is non-zero) is there a second IF test (using mod(x,STEPWTD)) to compute whether
    additional processing takes place.
    
    This modification was made separately to the develop branch after the branch release-v4.1.4
    was released. See wrf-model#1101. The purpose of this modification
    is to allow users access to the latest v4.1.* branch that works with NoahMP.
    
    As this will be a single issue release, the README and inc/version_decl are also modified
    in preparation for the release of WRF release-v4.1.5 with this PR.
    
    LIST OF MODIFIED FILES:
    M dyn_em/module_first_rk_step_part1.F
    M phys/module_surface_driver.F
    M README
    M inc/version_decl
    
    TESTS CONDUCTED:
    
    Jenkins test PASS (positively tests NoahMP)
    Regression test in NCAR-MMM classroom machine PASS.
    smileMchen committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    bf5b72b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7df4461 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2020

  1. Merge tag 'v4.1.5' into letmaik/wrf-4.1.5

    Finalize WRFV4.1.5 by merging bug fixes from release-v4.1.5 branch into master
    letmaik committed Mar 29, 2020
    Configuration menu
    Copy the full SHA
    9262e08 View commit details
    Browse the repository at this point in the history