-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add real8 support to CMake #13
Conversation
That's fine -- I will look at this once #9 is in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with me. Conditional to full checks passing after #9 is merged in.
We should add at least build tests for this as well before merging this in. |
I enabled build tests via Travis CI and Appveyor, where half of the configurations now build with USE_REAL8=1. This prevents adding another dimension to Azure Pipelines where we already have a lot of jobs. Given the comments in #11, we should probably in the README change
to
I would still keep the name Or we leave it as it is since we don't support platforms/compilers where real8 is not actually 8-byte reals... |
I'd leave the flag as is but I am OK with change in docs to |
Done. Let's target this feature for 4.1.1. So, do not merge until WRF-CMake 4.1 is released. |
Agree -- added to 4.1.1 milestone to make it easier to track. |
4.1.1 and 4.1.2 have been released -- do you still want to merge this in? Do we need to create releases? We can just wait for 4.2.0 otherwise... |
I'll merge it once CI passed. Please open a separate issue if you want to discuss updating to a new WRF version. |
Implements #11.
This needs some more testing.