Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [ST-1931] Implement custom domain languages #228

Merged
merged 36 commits into from
Mar 17, 2023
Merged

feat: [ST-1931] Implement custom domain languages #228

merged 36 commits into from
Mar 17, 2023

Conversation

bryanzerrudo
Copy link
Contributor

@bryanzerrudo bryanzerrudo commented Mar 7, 2023 •
edited
Loading

Purpose/goal of Pull Request (Issue #)

https://wovnio.atlassian.net/browse/ST-1931

Adds custom domain langs feature.

Comments

Mostly based from WOVNio/WOVN.php#127.

@bryanzerrudo bryanzerrudo marked this pull request as ready for review March 8, 2023 02:17
bryanzerrudo
bryanzerrudo commented Mar 8, 2023
View reviewed changes
lib/wovnrb.rb Outdated Show resolved Hide resolved
lib/wovnrb/headers.rb Outdated Show resolved Hide resolved
bstewart00
bstewart00 reviewed Mar 9, 2023
View reviewed changes
lib/wovnrb/store.rb Outdated Show resolved Hide resolved
bstewart00
bstewart00 reviewed Mar 16, 2023
View reviewed changes
lib/wovnrb.rb Outdated Show resolved Hide resolved
@bryanzerrudo
Merge branch 'master' into ST-1931
d365b53
@bryanzerrudo
refactor: [CR] Do not check against string
ae30884
@bryanzerrudo
fix: Incorrect Location for relative URLs
233d40f 
refactor: Return absolute URL for relative URLs for target language
test: Adjust / add tests
bstewart00
bstewart00 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@bstewart00 bstewart00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well done.

@bryanzerrudo bryanzerrudo changed the title feat: [ST-1931] Custom domain languages feat: [ST-1931] Implement custom domain languages Mar 17, 2023
@bryanzerrudo bryanzerrudo merged commit 7441004 into master Mar 17, 2023
@bryanzerrudo bryanzerrudo deleted the ST-1931 branch March 17, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstewart00 bstewart00 bstewart00 approved these changes

@iwai-wovn iwai-wovn iwai-wovn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryanzerrudo @bstewart00 @iwai-wovn