Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc comments and add missing parameter in getUrlsFromWebsiteId #38

Merged
merged 2 commits into from
Jun 10, 2017
Merged

Fix doc comments and add missing parameter in getUrlsFromWebsiteId #38

merged 2 commits into from
Jun 10, 2017

Conversation

simonschaufi
Copy link
Contributor

No description provided.

@thelfensdrfer
Copy link
Member

Can you check the indentation. It seems of at a few lines, especially the doc block comments. Shouldn't they be indented at the same level as the following method?

@simonschaufi
Copy link
Contributor Author

Sure, they should. I just see the mess. I would like to use PSR standards (use spaces). Can I reformat the whole file?

@thelfensdrfer
Copy link
Member

Yes you can! Thanks for your PR.

@VisualAppeal VisualAppeal deleted a comment from codecov-io Jun 10, 2017
@thelfensdrfer thelfensdrfer merged commit 725fc66 into VisualAppeal:master Jun 10, 2017
@simonschaufi simonschaufi deleted the bugfixes branch June 10, 2017 20:52
@simonschaufi
Copy link
Contributor Author

Thank you for merging this!

@VisualAppeal VisualAppeal deleted a comment from codecov-io Jun 10, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants